Cache access tokens client side #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutslakhorst
force-pushed
the
feature/3552/cached_access_tokens
branch
from
a262394 to
ea54414
Compare
woutslakhorst
force-pushed
the
feature/3552/cached_access_tokens
branch
from
ea54414 to
0e660b0
Compare
woutslakhorst
requested review from
reinkrul,
gerardsn and
stevenvegt
as code owners
reinkrul
reviewed
Nov 22, 2024
| if err != nil { | ||
| // this can be an internal server error, a 400 oauth error or a 412 precondition failed if the wallet does not contain the required credentials | ||
| return nil, err | ||
| } | ||
| ttl := accessTokenValidity | ||
| if tokenResult.ExpiresIn != nil { | ||
| ttl = time.Second * time.Duration(*tokenResult.ExpiresIn) |
There was a problem hiding this comment.
It's a pointer, probably because the spec says it's optional. In our implementation it's not but you never know.
storage/session.go
Outdated
| } | ||
| // TTL can't go below 0 because that is translated to "no expiration" by the library | ||
| // in that case it should be 1 nanosecond | ||
| if opts.ttl < 0 { |
reinkrul
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache access tokens per request. Subsequent requests are fulfilled from cache.
Added SessionOption to allow for custom
ttlon session store.Only implemented for
auth.iam, not forauth/v1closes #3552